feat: add Broadcasts.cancel() and cancel_async() - #250
Open
dielduarte wants to merge 1 commit into
Open
Conversation
Cancels a queued or scheduled broadcast via POST /broadcasts/:id/cancel, mirroring Emails.cancel()'s shape (empty params, id-only). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 5/5
- In
tests/broadcasts_async_test.py,cancel_asyncis only covered on the success path, so a no-content response regression could slip through without catching an expectedNoContentError; add aset_mock_json(None)failure-path test forcancel_asyncto align with the rest of the file’s exception coverage.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/broadcasts_async_test.py">
<violation number="1" location="tests/broadcasts_async_test.py:136">
P3: The cancel_async coverage here only exercises the success path. Every other method in this file has a paired raise-exception-when-no-content test; add one for cancel_async (set_mock_json(None), expect NoContentError) to keep the error path covered and consistent with the rest of the suite.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| } | ||
| ) | ||
|
|
||
| canceled = await resend.Broadcasts.cancel_async( |
Contributor
There was a problem hiding this comment.
P3: The cancel_async coverage here only exercises the success path. Every other method in this file has a paired raise-exception-when-no-content test; add one for cancel_async (set_mock_json(None), expect NoContentError) to keep the error path covered and consistent with the rest of the suite.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At tests/broadcasts_async_test.py, line 136:
<comment>The cancel_async coverage here only exercises the success path. Every other method in this file has a paired raise-exception-when-no-content test; add one for cancel_async (set_mock_json(None), expect NoContentError) to keep the error path covered and consistent with the rest of the suite.</comment>
<file context>
@@ -125,6 +125,20 @@ async def test_should_send_broadcasts_async_raise_exception_when_no_content(
+ }
+ )
+
+ canceled = await resend.Broadcasts.cancel_async(
+ "78261eea-8f8b-4381-83c6-79fa7120f1cf"
+ )
</file context>
This was referenced Aug 10, 2026
dielduarte
marked this pull request as ready for review
August 11, 2026 12:07
This was referenced Aug 11, 2026
drish
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Broadcasts.cancel(id)/cancel_async(id), callingPOST /broadcasts/:id/cancelto cancel a queued or scheduled broadcast.Emails.cancel()'s shape (empty params, id-only).Broadcasts.CancelResponse(object + id).Part of the broadcast cancel rollout: resend/resend-monorepo#8126, resend/resend-openapi#85, resend/resend-node#1059, resend/resend-docs#1722, resend/resend-go#144, resend/resend-java#122, resend/resend-php#135.
Test plan
pytest tests/broadcasts_test.py tests/broadcasts_async_test.py— 24/24 passingmypy resend/broadcasts/— clean🤖 Generated with Claude Code
Summary by cubic
Adds cancel support for broadcasts. Introduces
Broadcasts.cancel(id)andcancel_async(id)to stop queued or scheduled sends viaPOST /broadcasts/:id/cancel, matchingEmails.cancel().Broadcasts.cancel(id)andcancel_async(id)to cancel queued/scheduled broadcasts.Broadcasts.CancelResponse(returnsobjectandid).Written for commit 162fab3. Summary will update on new commits.